[webview_flutter_wkwebview] Remove specialization of 'map' to fix Swift warning #9810

jmagman · 2025-08-14T17:58:05Z

Introduced in #8311.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

gemini-code-assist

Code Review

This pull request correctly removes an explicit type specialization in a Swift map call to resolve a compiler warning. I've added a couple of suggestions. One is to correct the CHANGELOG entry, as the change affects the plugin's source code, not the example app. The other, more critical suggestion is to replace try! with try on the modified line to prevent a potential runtime crash and properly propagate errors, aligning with the function's throwing signature.

gemini-code-assist · 2025-08-14T17:58:48Z

...webview_flutter_wkwebview/Sources/webview_flutter_wkwebview/HTTPCookieProxyAPIDelegate.swift

    let registrar = pigeonApi.pigeonRegistrar as! ProxyAPIRegistrar

-    let keyValueTuples = try! properties.map<[(HTTPCookiePropertyKey, Any)], PigeonError> {
+    let keyValueTuples = try! properties.map {


Using try! can cause a crash if the map operation throws an error. The closure can throw an error, for example, for an unknown enum case or when sameSitePolicy is used on an older OS version. Since the pigeonDefaultConstructor function is marked with throws, the error should be propagated with try instead of try! to prevent a potential crash.

Suggested change

let keyValueTuples = try! properties.map {

let keyValueTuples = try properties.map {

I'm not a Swift expert, @hellohuanlin what's the idiomatic thing to do here? And is that correct in the context of this plugin?
There are no warnings without the !

Looking at the caller:

packages/packages/webview_flutter/webview_flutter_wkwebview/darwin/webview_flutter_wkwebview/Sources/webview_flutter_wkwebview/WebKitLibrary.g.swift

Lines 1654 to 1660 in 27a2302

do {

api.pigeonRegistrar.instanceManager.addDartCreatedInstance(

try api.pigeonDelegate.pigeonDefaultConstructor(pigeonApi: api, url: urlArg),

withIdentifier: pigeonIdentifierArg)

reply(wrapResult(nil))

} catch {

reply(wrapError(error))

It wraps pigeonDefaultConstructor call under a do/catch block, and if it throws, it replies error to the dart side.

So if you use try here, when it throws, it will be eventually propagated to dart side;
If you use try! here, when it throws, it will crash.

Given that this code is setup this way (throwable method + do/try/catch block), I'd say the expected usage is not to crash. So let's go with try.

packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md

jmagman · 2025-08-14T17:59:38Z

...webview_flutter_wkwebview/Sources/webview_flutter_wkwebview/HTTPCookieProxyAPIDelegate.swift

    let registrar = pigeonApi.pigeonRegistrar as! ProxyAPIRegistrar

-    let keyValueTuples = try! properties.map<[(HTTPCookiePropertyKey, Any)], PigeonError> {
+    let keyValueTuples = try! properties.map {


It was complaining because line 13 above in the function declaration already contains the type information [HttpCookiePropertyKey: Any]

Interesting! The old rule is that yon can always explicitly provide types, and what's more, sometimes you must explicitly provide types for super long statements where swift compiler fails auto-infer the types).

hellohuanlin · 2025-09-15T16:57:06Z

...webview_flutter_wkwebview/Sources/webview_flutter_wkwebview/HTTPCookieProxyAPIDelegate.swift

    let registrar = pigeonApi.pigeonRegistrar as! ProxyAPIRegistrar

-    let keyValueTuples = try! properties.map<[(HTTPCookiePropertyKey, Any)], PigeonError> {
+    let keyValueTuples = try properties.map {


didn't i review this PR before? gosh my memory is getting messed up!

… app to prevent a Swift warning

auto-submit · 2025-09-16T05:41:16Z

autosubmit label was removed for flutter/packages/9810, because - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-09-24T14:26:20Z

autosubmit label was removed for flutter/packages/9810, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

…to fix Swift warning (flutter/packages#9810)

flutter/packages@1a7075b...3d926aa 2025-11-04 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.1.0 to 5.3.0 in /packages/espresso/android (flutter/packages#10348) 2025-11-04 engine-flutter-autoroll@skia.org Roll Flutter from 6f8abdd to 027f2e4 (26 revisions) (flutter/packages#10335) 2025-11-03 stuartmorgan@google.com [google_sign_in] Remove use of OCMock (flutter/packages#10290) 2025-11-03 stuartmorgan@google.com [interactive_media_ads] Pin iOS dependency maximum (flutter/packages#10349) 2025-10-30 magder@google.com [webview_flutter_wkwebview] Remove specialization of 'map' to fix Swift warning (flutter/packages#9810) 2025-10-30 engine-flutter-autoroll@skia.org Roll Flutter from df72035 to 6f8abdd (16 revisions) (flutter/packages#10327) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

jmagman self-assigned this Aug 14, 2025

github-actions bot added platform-ios platform-macos p: webview_flutter labels Aug 14, 2025

gemini-code-assist bot reviewed Aug 14, 2025

View reviewed changes

jmagman commented Aug 14, 2025

View reviewed changes

jmagman changed the title ~~[webview_flutter_wkwebview] Remove specialization of 'map' in example app to fix Swift warning~~ [webview_flutter_wkwebview] Remove specialization of 'map' to fix Swift warning Aug 14, 2025

jmagman marked this pull request as ready for review August 14, 2025 18:09

jmagman requested a review from LouiseHsu as a code owner August 14, 2025 18:09

jmagman requested a review from hellohuanlin August 14, 2025 18:09

jmagman force-pushed the specialize-map branch from 1c9f84a to ca25084 Compare August 20, 2025 15:58

hellohuanlin approved these changes Sep 15, 2025

View reviewed changes

[webview_flutter_wkwebview] Remove specialization of 'map' in example…

b7e28cd

… app to prevent a Swift warning

jmagman force-pushed the specialize-map branch from ca25084 to b7e28cd Compare September 16, 2025 05:32

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2025

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

jmagman added 2 commits October 16, 2025 10:23

Merge branch 'main' into specialize-map

2dd4083

Merge branch 'main' into specialize-map

99d563b

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 30, 2025

auto-submit bot merged commit 5fc2fd7 into flutter:main Oct 30, 2025
80 checks passed

jmagman deleted the specialize-map branch October 30, 2025 23:02

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2025

5fc2fd716 [webview_flutter_wkwebview] Remove specialization of 'map' …

cffee36

…to fix Swift warning (flutter/packages#9810)

engine-flutter-autoroll mentioned this pull request Oct 31, 2025

Roll Packages from 1a7075b09ef1 to 5fc2fd7169cf (2 revisions) flutter/flutter#177842

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2025

5fc2fd716 [webview_flutter_wkwebview] Remove specialization of 'map' …

52ec76a

…to fix Swift warning (flutter/packages#9810)

engine-flutter-autoroll mentioned this pull request Oct 31, 2025

Roll Packages from 1a7075b09ef1 to 5fc2fd7169cf (2 revisions) flutter/flutter#177849

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2025

5fc2fd716 [webview_flutter_wkwebview] Remove specialization of 'map' …

fec161c

…to fix Swift warning (flutter/packages#9810)

engine-flutter-autoroll mentioned this pull request Nov 3, 2025

Roll Packages from 1a7075b09ef1 to 5fc2fd7169cf (2 revisions) flutter/flutter#177916

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 4, 2025

5fc2fd716 [webview_flutter_wkwebview] Remove specialization of 'map' …

a4020d4

…to fix Swift warning (flutter/packages#9810)

engine-flutter-autoroll mentioned this pull request Nov 4, 2025

Roll Packages from 1a7075b09ef1 to 8c13c08ca683 (5 revisions) flutter/flutter#177990

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 4, 2025

5fc2fd716 [webview_flutter_wkwebview] Remove specialization of 'map' …

a66c489

…to fix Swift warning (flutter/packages#9810)

engine-flutter-autoroll mentioned this pull request Nov 4, 2025

Roll Packages from 1a7075b09ef1 to 3d926aa495d3 (6 revisions) flutter/flutter#177998

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[webview_flutter_wkwebview] Remove specialization of 'map' to fix Swift warning #9810

[webview_flutter_wkwebview] Remove specialization of 'map' to fix Swift warning #9810

jmagman commented Aug 14, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Aug 14, 2025

Uh oh!

jmagman Aug 14, 2025

Uh oh!

hellohuanlin Aug 19, 2025

Uh oh!

jmagman Aug 20, 2025

Uh oh!

Uh oh!

jmagman Aug 14, 2025

Uh oh!

hellohuanlin Aug 19, 2025

Uh oh!

hellohuanlin Sep 15, 2025

Uh oh!

auto-submit bot commented Sep 16, 2025

Uh oh!

auto-submit bot commented Sep 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	let keyValueTuples = try! properties.map {
	let keyValueTuples = try properties.map {

	do {
	api.pigeonRegistrar.instanceManager.addDartCreatedInstance(
	try api.pigeonDelegate.pigeonDefaultConstructor(pigeonApi: api, url: urlArg),
	withIdentifier: pigeonIdentifierArg)
	reply(wrapResult(nil))
	} catch {
	reply(wrapError(error))

[webview_flutter_wkwebview] Remove specialization of 'map' to fix Swift warning #9810

[webview_flutter_wkwebview] Remove specialization of 'map' to fix Swift warning #9810

Conversation

jmagman commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 16, 2025

Uh oh!

auto-submit bot commented Sep 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmagman commented Aug 14, 2025 •

edited

Loading